-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add driver-install packaging metadata + support for INF only drivers #246
Open
ayodejiige
wants to merge
14
commits into
microsoft:main
Choose a base branch
from
ayodejiige:enable-null-driver-builds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
77e8e5a
Add packages to install alongside the driver to wdk metadata
0da2779
fix: resolve cargo clippy warnings
161e5fb
Cargo Make working for INF only driver.
d796125
Add cargo make task to copy package files to driver package folder.
e23a9e5
add sample null driver workspace with sample app and driver packages
d515c39
refactor: update error messages for unsupported driver configurations…
70c641d
refactor: reorganize imports and improve code formatting
e5855e9
refactor: improve code formatting
6ec6d40
fix: downgrade regex version to 1.10.5 and update lifetime annotation…
a1fd802
feat: add condition for package file copying based on environment var…
c82c7bc
fix: Revert Cargo.lock files.
0c24cda
fix: Revert root Cargo.lock
23e48ce
feat: add regex dependency to multiple Cargo.lock files and update it…
062467e
fix: revert Cargo.lock for tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows-drivers-rs/crates/wdk-build/src/cargo_make.rs
Line 824 in 10a8e37
Previously, there was an assumption that there must be wdk-build in the workspace. This is no longer true now there can be a null driver in the workspace without any actual driver code being built (so no wdk-build in the graph).
In the wdk-build only case, we should also see if putting a workspace dep on wdk-build yields anything in the cargo metadata output.
maybe also worth putting a specific message for the case of no-wdk in workspace since that would typically be a null-driver-only workspace scenario