This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Refactored Common Interfaces Package #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
An issue in travis is preventing this building;
|
|
Retest pls |
|
Retest |
as Secure Storage in the event that the module is used in a JDK9+ modular implementation.
cbm64chris
force-pushed
the
refactor_auth_common_packages
branch
from
89e2e13 to
6cd4dfd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was attempting to use the auth-secure-storage library in a modular JDK13 project. Jlink cannot use the package because it has a dependency on auth-common which exports the same package name.
Resolves #24
I have refactored all packages and usages in all reactor modules to use com.microsoft.alm.common.storage instead of com.microsoft.alm.storage.