Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Fakes version in Test Platform #3736

Closed

Conversation

AbhitejJohn
Copy link
Contributor

Description

Pulling in the latest Fakes package into the Test Platform.

@AbhitejJohn
Copy link
Contributor Author

I'll validate the generated package on local commandlin scenarios. Do let me know if there are other workflows I should consider too.
/cc: @vritant24

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbhitejJohn
Copy link
Contributor Author

Waiting to use the same version we publish on nuget.

@Evangelink
Copy link
Member

@AbhitejJohn Build is fixed, I am waiting for your manual check of the NuGet before merging this one out.

@AbhitejJohn
Copy link
Contributor Author

Yes, I had one more fix that I should have in the next day or so. Will push out a nuget package for that and update this PR.

@Evangelink
Copy link
Member

@AbhitejJohn let us know when this is ready for merge.

@AbhitejJohn
Copy link
Contributor Author

@Evangelink : To reduce the churn in 17.3, I'm planning to merge this in after we snap the branch for 17.4. I'll retry the fakes scenarios as well against the latest changes.

@Evangelink
Copy link
Member

@AbhitejJohn Do you need some help with this one?

@AbhitejJohn
Copy link
Contributor Author

Abandoned in favor of #3912

@AbhitejJohn AbhitejJohn deleted the dev/aajohn/fakesupdate branch August 23, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants