-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Fakes version in Test Platform #3736
Conversation
I'll validate the generated package on local commandlin scenarios. Do let me know if there are other workflows I should consider too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@AbhitejJohn You will need to also update https://github.com/microsoft/vstest/blob/main/scripts/verify-nupkgs.ps1#L17
Waiting to use the same version we publish on nuget. |
@AbhitejJohn Build is fixed, I am waiting for your manual check of the NuGet before merging this one out. |
Yes, I had one more fix that I should have in the next day or so. Will push out a nuget package for that and update this PR. |
@AbhitejJohn let us know when this is ready for merge. |
@Evangelink : To reduce the churn in 17.3, I'm planning to merge this in after we snap the branch for 17.4. I'll retry the fakes scenarios as well against the latest changes. |
@AbhitejJohn Do you need some help with this one? |
Abandoned in favor of #3912 |
Description
Pulling in the latest Fakes package into the Test Platform.