Port source api changes #1295
Merged
Port source api changes #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix build issue for PlatformAbstractions on non windows environment. Fake .NET desktop build environment if machine is non-windows. Fixes microsoft#1222. * Use Ubuntu 14.04 since it is used in source builds. * Use exit code from build instead of log function. Fix names for TestPlatform.nuspec and path to testhost.x86 binaries. * Remove dependency on Mono for net4x builds. Use multitarget package instead. * Single build path for unix. Removed mono dependency checks. Fixes microsoft#1153. * Port vstest repo patches. Add support for repo API. https://github.com/dotnet/source-build/blob/dev/release/2.0/Documentation/RepoApi.md * Fix PR comments. * Use numeric comparisons instead of boolean in bash.
smadala
approved these changes
Nov 15, 2017
| <!-- Required for resolution of desktop dependencies in non windows environment. | ||
| We've to set to net46 since the net451 and other packages have assemblies in wrong case. | ||
| E.g. System.XML instead of System.Xml. --> | ||
| <PackageReference Include="Microsoft.TargetingPack.NETFramework.v4.6"> |
There was a problem hiding this comment.
In 15.3 we target net46, Is this required?
There was a problem hiding this comment.
Yes, because we have removed dependency on mono. This package is the source for .net assemblies during build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix build issue for PlatformAbstractions on non windows environment.
Fake .NET desktop build environment if machine is non-windows.
Fixes Build on Linux and Mac are failing because of uap10.0 TFM #1222.
Use Ubuntu 14.04 since it is used in source builds.
Use exit code from build instead of log function.
Fix names for TestPlatform.nuspec and path to testhost.x86 binaries.
Remove dependency on Mono for net4x builds.
Use multitarget package instead.
Single build path for unix.
Removed mono dependency checks. Fixes vstest shouldn't have a different build if mono happens to be installed on the machine #1153.
Port vstest repo patches.
Add support for repo API.
https://github.com/dotnet/source-build/blob/dev/release/2.0/Documentation/RepoApi.md
Fix PR comments.
Use numeric comparisons instead of boolean in bash.
Related issue
dotnet/source-build#178