Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #99854 make 'Edit in settings.json' add object-type default #99912

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #99854

To test:

  1. Clone https://github.com/gjsjohnmurray/vscode-extension-samples/tree/test-vscode-99854
  2. Run the modified configuration-sample this branch contains.
  3. Open Settings UI.
  4. Locate Configuration Samples section under Extensions and click 'Edit in settings.json' link
    image
  5. After dismissing the automatically-opened quickpick, verify that the defaults for this object-type setting have been inserted:
	"conf.resource.insertEmptyLastLine": {
	
		"one": "FirstDefault",
		"two": {
			"alpha": "abc",
			"number": 123
		}
	}

@gjsjohnmurray
Copy link
Contributor Author

@sandy081 are you the best person to look at this?

@sandy081 sandy081 self-requested a review June 12, 2020 12:46
@sandy081 sandy081 self-assigned this Jun 12, 2020
@sandy081 sandy081 added this to the June 2020 milestone Jun 12, 2020
@sandy081 sandy081 merged commit 74f9a3d into microsoft:master Jun 12, 2020
@gjsjohnmurray gjsjohnmurray deleted the fix-99854 branch June 12, 2020 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Edit in settings.json' does not add default for object-type setting
2 participants