migrate search to use new setting #89190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
sandy081
approved these changes
Jan 24, 2020
| for (const { viewDescriptor, collapsed, index, size } of added) { | ||
| const pane = this.createView(viewDescriptor, | ||
| { | ||
| id: viewDescriptor.id, | ||
| title: viewDescriptor.name, | ||
| actionRunner: this.getActionRunner(), | ||
| expanded: !collapsed | ||
| expanded: !collapsed, | ||
| location: currentLocation |
There was a problem hiding this comment.
why does location need to be passed? ViewPane can get the location from IViewDescriptorService ?
| @@ -565,6 +566,27 @@ export class ViewsService extends Disposable implements IViewsService { | |||
| return undefined; | |||
| } | |||
|
|
|||
| getActiveViewById(id: string): IView | null { | |||
There was a problem hiding this comment.
Better name is getActiveViewWithId ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refs #85164
In order for this to work, search needed a way to get the proper bg color and progress location. This was handled by extending
ViewPane.Additionally many helper methods needed a way to get the SearchView object. This was handled by extending
IViewsServiceto get the current active composite by container id and exposingViewPaneContainerfunctionality to support getting an IView/ViewPane by id.