Allow ThemeIcon for menu items #85814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
commented
Nov 29, 2019
jrieken
commented
Nov 29, 2019
| }); | ||
| if (codicon) { | ||
| DOM.addClass(templateData.icon, codicon); | ||
| templateData.icon.className = iconClass ? `custom-view-tree-node-item-icon ${iconClass}` : ''; |
There was a problem hiding this comment.
@alexr00 fyi and for another pair of eyes. This adds support for ThemeIcons that are different than the file & folder constant, e.g new ThemeIcon('zap')
There was a problem hiding this comment.
I don't think this will correctly handle the codicon url that @eamodio added. Instead of checking for iconUrl you might need to check for the scheme and authority as it currently does.
There was a problem hiding this comment.
The plan is that this replaces the codicon-uri so that uris are used for resources on disk/web and that ThemeIcon is used for codicon
alexr00
approved these changes
Nov 29, 2019
|
Great - I will go ahead a merge this so that I have build on Monday against which I can continue my extension work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #84695 and #85624