Move user data to ~/.vscode[-variant]/user-data and automatically set root user data dir #5570
Conversation
Permanently move the user data to a sub-folder of the config directory for the current variant of code. For example: - ~/.config/Code -> ~/.vscode/user-data - ~/.config/Code\ -\ OSS -> ~/.vscode-oss/user-data - ~/.config/Code-Development -> ~/.vscode-oss-dev/user-data Fixes #3884
|
By analyzing the blame information on this pull request, we identified @joaomoreno, @dbaeumer and @bpasero to be potential reviewers |
|
Actually, may not need the |
| if (process.env.VSCODE_DEV) { | ||
| var appData = app.getPath('appData'); | ||
| app.setPath('userData', path.join(appData, 'Code-Development')); | ||
| configDir += '-dev'; |
There was a problem hiding this comment.
Do we need this actually? We already have this: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-main/env.ts#L79
|
@Tyriar I did a quick scan over the changes. I hope you understand that this change - if done wrong - will break every existing user out there with no easy way to get back and possible corruption. I am not confident to do such a change so late in the game without extensive testing across all platforms and all corner cases. |
|
@bpasero I'm reasonable confident it will work fine on OS X, it's completely untested on Windows atm. It might be best to defer to May considering I'll be gone starting next week (only 1 work day after today). I guess we'll make |
|
Closing this off as the conflicts are pretty significant. Hoping to have another crack at this in July debt week. |
@bpasero let me know what you think
Fixes #3884 and #5561