Use tags for filtering settings #55198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Jul 27, 2018
| @@ -179,6 +180,12 @@ export class SettingsEditor2 extends BaseEditor { | |||
| this.searchWidget.clear(); | |||
| } | |||
|
|
|||
| filterByTag(tag: string): void { | |||
There was a problem hiding this comment.
it is Rob. it is.
roblourens
approved these changes
Jul 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, we move to using tags to filter the settings. Since the search box gets pre-filled with tags, we dont need to maintain checks in the menu or the green badge on the gear.
Also added a separator to the menu
Related to #54354