Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to opt-out of features that send online requests in the background #55097

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

ramya-rao-a
Copy link
Contributor

As per #54354 (comment), we want to have settings that enable users to switch off any background features that make online requests.

This PR adds such a setting for the npm extension which fetches data from https://registry.npmjs/org and https://registry.bower.io to provide auto-completion and information on hover features on npm dependencies.

@ramya-rao-a ramya-rao-a requested a review from egamma July 25, 2018 22:53
@ramya-rao-a ramya-rao-a self-assigned this Jul 25, 2018
@ramya-rao-a
Copy link
Contributor Author

@egamma Merging this in as we want this to be in Monday's Insiders build as part of #54354. Regardless, please do take a look and let me know if you have any concerns and we can address them next week.

@ramya-rao-a ramya-rao-a merged commit f51c30d into master Jul 27, 2018
@ramya-rao-a ramya-rao-a deleted the ramyar/npm-online branch August 11, 2018 01:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant