Offline mode #54831
Offline mode #54831
Conversation
ramya-rao-a
force-pushed
the
offline-mode
branch
from
b755231 to
7fef11f
Compare
ramya-rao-a
force-pushed
the
offline-mode
branch
from
8849a67 to
35d20ed
Compare
ramya-rao-a
force-pushed
the
offline-mode
branch
from
d54056b to
b6dd980
Compare
ramya-rao-a
requested review from
sandy081,
JacksonKearl,
joaomoreno,
mjbvz and
sbatten
ramya-rao-a
force-pushed
the
offline-mode
branch
from
bc09c7b to
67b0554
Compare
|
menu stuff LGTM |
|
|
||
| run(): TPromise<any> { | ||
| if (this.storageService.getBoolean(this.disclaimerStorageKey, StorageScope.GLOBAL, false) === false) { | ||
| this.notificationService.prompt(Severity.Info, localize('offlineModeDisclaimer', "VS Code cannot stop extensions from making network requests in offline mode. If extensions make such requests, please log an issue against them."), [ |
There was a problem hiding this comment.
Is there a way for extensions to check if the user is in offline mode?
There was a problem hiding this comment.
@mjbvz Yes, they can look at the value for the workbench.enableOfflineMode setting. I havent yet gone through built-in extensions to ensure they are able to comply with the offline mode. That will be another PR.
There was a problem hiding this comment.
Ok, so that will added to vscode.d.ts? Or read the setting value directly?
There was a problem hiding this comment.
Read the setting value directly
|
Extensions looks good. |
| }, | ||
| 'workbench.enableOfflineMode': { | ||
| 'type': 'boolean', | ||
| 'description': nls.localize('settingsOfflineMode', "Enables offline mode where no requests are made over the network by VS Code."), |
There was a problem hiding this comment.
I wonder if this wording should be changed to say that no requests are made to Microsoft, as we do still make requests to SCM providers, and there's nothing we can do to stop extensions (so far as I know)
ramya-rao-a
force-pushed
the
offline-mode
branch
from
a3c2221 to
7d83013
Compare
|
Abandoning this PR as per #54354 (comment) |
This PR implements features detailed in #54354
Adding below folks as reviewers
@sbatten for Menu entries
@joaomoreno for vscode updates
@sandy081 for extension view and updates
@JacksonKearl for extension recommendations
@mjbvz for Release notes and logUploader
Pending items to be taken up in another PR