Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not receive extension updates #54612

Closed
wants to merge 4 commits into from
Closed

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Jul 18, 2018

Related to #54354

With the addition of this setting, user can choose not to receive extension updates, thus enabling the last piece of the offline mode story.

@joaomoreno The corresponding setting for VS Code updates is the update.channel. What was the reason to have this setting take an enum of default and none instead of a boolean?

@ramya-rao-a ramya-rao-a requested a review from sandy081 July 18, 2018 20:49
@ramya-rao-a ramya-rao-a self-assigned this Jul 18, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Jul 19, 2018

update.channel is a very old setting. We should've done a boolean from the get-go but a lot of users already had it set to none, so we decided to go with this instead.

I'm confused by this setting... I think the expression receive updates doesn't do it justice. Should it maybe be extensions will not be updated instead? Or rather VS Code will not check for extension updates.

@sandy081
Copy link
Member

Why not having a single switch for offline mode and others react based on it instead of having settings for each? If we want per component, then we can extend the offline setting to define per componenet.

@ramya-rao-a
Copy link
Contributor Author

Good point, updated #54354 accordingly.

@joaomoreno joaomoreno deleted the recieve-updates branch August 2, 2018 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants