Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED: issue window opened as modal/child, fixes #42024 #42028

Merged
merged 3 commits into from
Jan 23, 2018

Conversation

warpdesign
Copy link
Contributor

I think the issue reporter window shouldn't be opened as always on top. This PR opens it as modal instead.

See #42024.

@bpasero
Copy link
Member

bpasero commented Jan 23, 2018

One thing to keep in mind is that the issue reporter can be opened without any other window being open.

@nico-onmap
Copy link

Didn't know that: how to reproduce this behavior?

@bpasero
Copy link
Member

bpasero commented Jan 23, 2018

@nico-onmap the idea is that from the help menu you can "Report Issue" and it would open the reporter.

@nico-onmap
Copy link

nico-onmap commented Jan 23, 2018

Right, I was thinking about Windows where you cannot have a menu bar without a window. But on macOS (and Linux?) it can happen indeed.

@bpasero
Copy link
Member

bpasero commented Jan 23, 2018

@nico-onmap yeah macOS only

@nico-onmap
Copy link

@bpasero This should handle macOS special case properly now.

@nico-onmap
Copy link

After all, using modal option wasn't such a good idea: in macOS, sheets are used when modal is specified, and they have no close button, so there was no way to close the issue reporter without sending a new report.

I only left the parent option, which will be null if there is no window opened which is fine: this is the default option for this paremeter.

@RMacfarlane
Copy link
Contributor

@nico-onmap Thanks, this looks good

@RMacfarlane RMacfarlane merged commit 7155f39 into microsoft:master Jan 23, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants