Fix #41080

[KamilSzot]

No description provided.

[wangpung12]

Good

[sandy081]

@KamilSzot It is not mandatory to have a repository, so gallery.assets.repository can be null. Hence I would put null check here similar to others.

[KamilSzot]

There's already code nearby that generates repository with empty urls if repo urls can't be found in version.properties: https://github.com/KamilSzot/vscode/blob/e2115a55c22089fa384b332e5b0d8011b587b29f/src/vs/platform/extensionManagement/node/extensionGalleryService.ts#L219

My fix just does the same for the case when there are no version.properties at all.

O course you can just put in the check, that was my first instinct as well. I just wasn't sure if that was the only place in the whole codebase that depended on repository not being null and I saw that in the case when repo url can't be found, the existing code returns object with empty urls rather than null.

[sandy081]

Ok makes sense.