Run hygiene in a dedicated Travis job #41372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
|
|
Pretty cool! Yeah pretty much all others are waterfallish... |
|
@joaomoreno too bad. Curious, what does optimize do (that the tests depend on)? |
|
Interesting that you bring that up. Those tests are supposed to run in the bundled AMD sources (which is what optimize does)... not sure it actually does that... I'll investigate. |
|
OK That's embarassing:
Merged that change too. Thanks for the keen eye @felixfbecker |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back again with some build speedups.
Biggest time sink atm is hygiene with 164.90s, which is an operation that does not depend on the project being compiled before and is the same on macOS and Linux - so it makes sense to run it in a parallel job, only on Linux.
Potentially other jobs could be run in parallel too but I am not sure - what's the relation between
compile,optimizeand test? Doesoptimizedepend oncompile, andtestdepend onoptimize? What about tsc monaco?Given AppVeyor does not run
optimizeat all I assume that could be in a parallel job too?