add option to disable terminal exit alert #40861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Dec 27, 2017
| @@ -687,7 +689,8 @@ export class TerminalInstance implements ITerminalInstance { | |||
| this._isExiting = true; | |||
| this._process = null; | |||
| let exitCodeMessage: string; | |||
| if (exitCode) { | |||
|
|
|||
| if (exitCode && this.configurationService.getValue('terminal.integrated.showExitAlert')) { | |||
There was a problem hiding this comment.
Currently all interactions with the config service is managed within TerminalConfigHelper, could you change to use this._configHelper.config.showExitAlert instead? You'll also need to add it to the interface defined in terminal.ts
Tyriar
reviewed
Dec 31, 2017
| @@ -687,7 +687,8 @@ export class TerminalInstance implements ITerminalInstance { | |||
| this._isExiting = true; | |||
| this._process = null; | |||
| let exitCodeMessage: string; | |||
| if (exitCode) { | |||
|
|
|||
| if (exitCode && this._configHelper.config.showExitAlert) { | |||
There was a problem hiding this comment.
Looking at this again I think the showExitAlert needs to be added to this line at the bottom of the function:
this._messageService.show(Severity.Error, exitCodeMessage)exitCodeMessage is shared between both the message box and also tasks which will be output to the terminal if it fails. In the current state when tasks fail an empty line will be added to the terminal when the task fails instead of the message.
…0503-add-option-to-disable-terminal-exit-alert
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40503