issue: #40373 default setting for panel location #40559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidorn
reviewed
Dec 22, 2017
| 'type': 'string', | ||
| 'enum': ['bottom', 'right'], | ||
| 'default': 'bottom', | ||
| 'description': nls.localize('panelDefaultLocation', "Controls the location of the panel. It can either show at the bottom or on the right of the workbench.") |
There was a problem hiding this comment.
I think this controls the default location, so I would prefer the folowing
`"Control the default location of the panel."
isidorn
reviewed
Dec 22, 2017
| @@ -153,6 +153,7 @@ const configurationValueWhitelist = [ | |||
| 'php.validate.run', | |||
| 'workbench.welcome.enabled', | |||
| 'workbench.startupEditor', | |||
| 'workbench.panel.defaultLocation', | |||
There was a problem hiding this comment.
This is not needed imho, please remove it.
|
@pfongkye I have added 2 minor comments. Please address them and merge latest master into your PR, resolve conflicts and we can merge this in. Thanks a lot 🍻 |
|
@isidorn I made the changes and merged master. Thanks for the review 👍 |
|
@pfongkye this looks great now, thanks a lot I merged it in 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.