Adds "copy on select" feature (with setting) #38287
Conversation
| @@ -120,6 +120,11 @@ configurationRegistry.registerConfiguration({ | |||
| 'type': 'boolean', | |||
| 'default': TERMINAL_DEFAULT_RIGHT_CLICK_COPY_PASTE | |||
| }, | |||
| 'terminal.integrated.copyOnSelection': { | |||
| 'description': nls.localize('terminal.integrated.copyOnSelection', "When set, text selected in the terminal will be copied to the clipboard."), | |||
There was a problem hiding this comment.
Not actually sure how localization works in this project. Is anything else needed to properly localize this string?
| @@ -120,6 +120,11 @@ configurationRegistry.registerConfiguration({ | |||
| 'type': 'boolean', | |||
| 'default': TERMINAL_DEFAULT_RIGHT_CLICK_COPY_PASTE | |||
| }, | |||
| 'terminal.integrated.copyOnSelection': { | |||
| 'description': nls.localize('terminal.integrated.copyOnSelection', "When set, text selected in the terminal will be copied to the clipboard."), | |||
|
Looks like the test failures are unrelated |
|
I just noticed after further testing that this doesn't work when dragging the selection and releasing the mouse outside of the terminal element. You will probably need to use selection to catch this as I would prefer not add a global listener. |
|
It also doesn't seem to work if you select a text range by double clicking and your unable to paste the selected text without first right clicking (least not on my mac). |
|
@Phunky hm, that works fine for me on my mac. 😕 |
|
@Tyriar 21821 is the top search result for this issue, and it says:
I'm so happy about this feature, but almost gave up when I saw that comment. The conversation is locked, but perhaps there is a way to add a note so others find the correct setting? |
|
@likesalmon good call, done 😃 |
I have to double right click to paste something I've selected... Windows 10 BTW. |
|
@richard-scott right click behaves differently on each platform but can be configured, see the |
mouseupevent in the integrated terminal; I think this satisfies the issue, as selecting with the keyboard doesn't copy to clipboard in any terminal AFAIK