copy from terminal doesn't work #31902

[warpdesign]

Copy from terminal panel didn't work if the mouse was released outside of the _xterm.element: in this case, the mouseup event wasn't triggered.

I fixed the problem by adding a boolean to track down when the mousedown event is triggered on _xterm.element. In this case, the selection is refreshed when the mouseup event bubbles up to the document.

Fixes #31902

[Tyriar]

I'd prefer if this listener was only active after a mousedown and disposed of itself on mouseup, otherwise this will run on every mouse click. You can probably do this all within the mousedown listener without the need to introduce more properties to TerminalInstance.

Also this listener will also make it very easy to implement #36271 👍

[warpdesign]

Oh you're right: that's much better.

[warpdesign]

@Tyriar I think I made the necessary changes: could you review it again?

This bug is driving me crazy :)

[Tyriar]

And I'm back! I can't actually seem to reproduce, on mac at least. Am I missing something?

1. Open terminal
2. ll (generated a bunch of output)
3. Scroll up a little
4. Select some text, trigger mouseup when it's to the left of the terminal panel
5. ctrl/cmd+c
6. ctrl/cmd+v

[warpdesign]

I can reproduce it with Windows 10: maybe this is Windows only ?

1. downloaded insider build
2. activated the option to copy on selection
3. select text and release the mouse outside of terminal div
4. paste: ctrl+v

Nothing is pasted. If I release the mouse inside the terminal div it works as expected.

Edit: that's the version that I installed:

Version 1.20.0-insider
Commit f9115349ef09cfef2bed669680d10ac58b490dce
Date 2017-12-21T16:36:58.030Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

[Tyriar]

@warpdesign yeah you're right, the problem is actually with the Windows only keybinding which is why I couldn't see it

[Tyriar]

Made a few tweaks, will merge after CI is happy