-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying README #28736
Clarifying README #28736
Conversation
Clarifying product name and its licensing. Related to microsoft#60, microsoft#1230, microsoft#2982, microsoft#3029, microsoft#5342, microsoft#17996. Based on @chrisdias [comment](microsoft#2983 (comment)) and [comment](microsoft#60 (comment))
@slodki, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @waderyan to be potential reviewers. |
<p align="center"> | ||
<img alt="VS Code in action" src="https://cloud.githubusercontent.com/assets/11839736/16642200/6624dde0-43bd-11e6-8595-c81885ba0dc2.png"> | ||
</p> | ||
|
||
Code is updated monthly with new features and bug fixes. | ||
You can download sources of released versions from [GitHub Releases](https://github.com/Microsoft/vscode/releases). | ||
Building binaries for Windows, OS X and Linux [instructions](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run-from-source) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Mac instead of OS X?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway use macOS. OS X is outdated: https://en.wikipedia.org/wiki/MacOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just cited page at given URL - I don't know if these instructions work for the latest macOS version.
README.md
Outdated
* licensed under Microsoft [closed source custom product license](https://code.visualstudio.com/License) (EULA) | ||
* Extension Marketplace supported | ||
* crash reporting and telemetry enabled | ||
* user configuration and extensions stored in different directory then Code - Open Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: s/then/than/
README.md
Outdated
* Microsoft branding | ||
* licensed under Microsoft [closed source custom product license](https://code.visualstudio.com/License) (EULA) | ||
* Extension Marketplace supported | ||
* crash reporting and telemetry enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add that both can be disabled?
I've made a few changes to the |
Clarifying product name and its licensing.
Related to #60, #1230, #2982, #3029, #5342, #17996.
Based on @chrisdias comment and comment