Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception widget UI update with respect to DA protocol #23670

Merged
merged 3 commits into from
Mar 30, 2017
Merged

Exception widget UI update with respect to DA protocol #23670

merged 3 commits into from
Mar 30, 2017

Conversation

michelkaporin
Copy link
Contributor

Updated exception widget UI with respect to #22078 discussion, also fixes #23388.

@michelkaporin michelkaporin added this to the March 2017 milestone Mar 30, 2017
@isidorn
Copy link
Contributor

isidorn commented Mar 30, 2017

Looks good to me -> merging.
I did not test it, just did a code reivew, however verifys the issues should test it out extensivly.
@michelkaporin I guess you already tried it out?

@isidorn isidorn merged commit 03748e7 into microsoft:master Mar 30, 2017
@michelkaporin
Copy link
Contributor Author

sure @isidorn, I've tested it before creating PR.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.

Exception peek widget not showing for throw "Hello World"
3 participants
@michelkaporin @isidorn @msftclas