#22622 #23211
#22622 #23211
Conversation
|
@cristianhosu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @bpasero to be potential reviewers. |
|
@cristianhosu, |
|
@cristianhosu thank you for your PR. However we are currently in the endgame, which means we are wrapping up our March milestone. Due to that I will check this PR and provide feedback next week. |
|
@isidorn Hello, can you please check? |
|
@cristianhosu yes I plan to look into this today / tomorrow. Thanks for the reminder |
|
@cristianhosu great work! @joaomoreno how does the suggest widget steal the scrolling from the editor? |
|
@isidorn Thank you |
|
@cristianhosu sorry for the slow response, last week I was on vacation. |
|
Pushing to May since we are now in endgame, will merge it in next week. |
|
@isidorn I've pushed to the correct branch as far as i can tell, but AppVeyor and Travis CI have not completed. maybe this is the reason why it's not visible? |
|
@cristianhosu now it is good. I will merge it in and look into the scrolling issue. Thanks |
|
I have looked into the scrolling issue and to make this proper we need to use the |
|
I am running out of cycles for this milestone and will not have time to look into using |
|
Yup, I'll look into it :)
…On Mon, May 22, 2017 at 12:00 PM, Isidor Nikolic ***@***.***> wrote:
I am running out of cycles for this milestone and will not have time to
look into using DomScollableElement
<https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/ui/scrollbar/scrollableElement.ts#L370>
class. @cristianhosu <https://github.com/cristianhosu> are you intrested
into looking into this? Using this class will give us consistent scroll bar
design across vscode. Nowhere else do we use the native scroll bar and that
is the main reason why this PR can not be merged in right now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23211 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQ3E7mY31UCmWvm6EGrXFucEvHujDIHPks5r8U6tgaJpZM4MpHZ->
.
--
Cristian Hosu
+40740.058.711
|
|
@cristianhosu great, thanks! |
|
So, i've investigated and i've also made some changes but i can't seem to
run VS Code OSS Dev with all the expansions :)
I have my test app with some node.js and I cannot start that app from
within the OSS Dev version.
Can you please help with this?
I haven't changed anything in the launch.json of the vscode project, but i
think i should, like maybe a cmd line parameter?
…On Tue, May 23, 2017 at 10:34 AM, Isidor Nikolic ***@***.***> wrote:
@cristianhosu <https://github.com/cristianhosu> great, thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23211 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQ3E7rM8u11rjKeZj7NId6C1KkFxJpcOks5r8ovzgaJpZM4MpHZ->
.
--
Cristian Hosu
+40740.058.711
|
|
@cristianhosu thanks for looking into this further. One solution #20623 (comment) |
|
@cristianhosu let me know if there is anything else I can help with |
|
@isidorn I have finished. I've finally made time to investigate how to properly implement a DomScrollableElement and it worked. |
|
@cristianhosu great! Feel free to push those commits once they are ready so I can review them. |
|
@isidorn I have pushed. Sorry about that... i keep forgetting to do so, being used to TFS :) |
|
@cristianhosu absolutetly great work! Thanks a lot! |
|
Great work! |
|
@isidorn - thank you :) |
Please validate the layout and the implementation.
Need help making the scroll work from the mouse wheel inside the .debug-hover-widget