Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A followup to #171066 fixing zsh and fish shells implementations #223421

Merged

Commits on Jul 23, 2024

  1. A followup to microsoft#171066 fixing zsh and fish shells implementat…

    …ions
    
    microsoft#171066 introduced a fix for applying PATH prefix on macOS login shells that resolved microsoft#99878. However it had little issues for each shell implementation.
    This PR contains the following fixes:
    
    `bash` fix:
     - Add missing `:` separator in the path setter to avoid path corruption
     - Add missing quotes to avoid path interpretation
    
    `zsh` fix:
     - Add missing `:` separator in the path setter to avoid path corruption
     - Add missing quotes to avoid path interpretation
     - Move patching outside of `.zprofile` check as clean macOS install doesn't include this file, nevertheless PATH patching should still happen
    
     `fish` fix:
     - use `set -gx PATH` instead of `fish_add_path` as the latter has no effect on updating the path if entries already exist in it. Which is the case for some extensions, like [`vscode-micromamba`](https://github.com/mamba-org/vscode-micromamba) which modify process environment and after login shell rc processing path entries end up in the end.
    anton-matosov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4cbdf3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    097ad3a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. the separator has to be provided by the plugin

    as generic env append/prepend can't handle path
    separators, neither should it be handled here
    anton-matosov committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    140b61b View commit details
    Browse the repository at this point in the history