Fix #19550 #19551
Merged
Fix #19550 #19551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roblourens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @bpasero to be potential reviewers. |
|
@roblourens thanks a lot for the fix! This area needs to be improved so we avoid hacks like this in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17333, probably regressed by ed900e4
Need
console.log('a\nb')to be rendered as multiline, butconsole.log({ 'a\nb': 'c\nd' })to not be. So here, only skip the string height measurement if the variable has children (is an object/array) or has a name (is a prop of an object/array).This is a hack, I think the newlines in the preview need to be escaped somewhere since they aren't now, and the property values need to go through here after being escaped, which much happen elsewhere.