Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook CodeActionKind Support #192248

Merged
merged 11 commits into from
Sep 18, 2023
Merged

Notebook CodeActionKind Support #192248

merged 11 commits into from
Sep 18, 2023

Conversation

Yoyokrazy
Copy link
Contributor

@Yoyokrazy Yoyokrazy commented Sep 6, 2023

Fixes: #184028
Re: #179213

** This PR is continuing and adding onto the conversation from #187303. This was tested with the GHINB branch joh/civic-tahr

This PR:

  • adds the revised version of the Notebook CodeActionKind type to core
  • filters notebook kinds out of providers when triggered by an autosave (work for future, alongside a UI way to surface these to a nb user)
  • cleans up the notebook saveParticipant for CodeActions
  • revises the setting to align with editor CodeAction style and enum

The current logs from this branch with the change above are as follows when explicitly saving a GHINB

  • build GHINB ext with joh/civic-tahr branch
  • add the following to your settings.json: "notebook.codeActionsOnSave": { "notebook.source.normalizeVariableNames": "explicit" }
  • open sample github issue notebook with a few variables + queries
  • ctrl + s to explicitly save
image

The provider is created, and now only called against the first cell of the notebook upon an explicit save.

@Yoyokrazy Yoyokrazy requested review from jrieken and mjbvz September 6, 2023 00:08
@Yoyokrazy Yoyokrazy self-assigned this Sep 6, 2023
@vscodenpa vscodenpa added this to the September 2023 milestone Sep 6, 2023
@Yoyokrazy Yoyokrazy changed the title Filter Notebook CodeActions out of automatic triggers Notebook CodeActionKind Support Sep 8, 2023
@Yoyokrazy Yoyokrazy requested a review from rebornix September 8, 2023 17:51
rebornix
rebornix previously approved these changes Sep 11, 2023
@Yoyokrazy Yoyokrazy enabled auto-merge (squash) September 18, 2023 16:58
rebornix
rebornix previously approved these changes Sep 18, 2023
Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Yoyokrazy Yoyokrazy merged commit e6b8e03 into main Sep 18, 2023
5 checks passed
@Yoyokrazy Yoyokrazy deleted the milively/nb-CodeAction-filter branch September 18, 2023 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notebook. code action provider is called repeatedly for all cells
3 participants