-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook CodeActionKind Support #192248
Merged
Merged
Notebook CodeActionKind Support #192248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoyokrazy
changed the title
Filter Notebook CodeActions out of automatic triggers
Notebook CodeActionKind Support
Sep 8, 2023
rebornix
previously approved these changes
Sep 11, 2023
rebornix
previously approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
rebornix
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #184028
Re: #179213
** This PR is continuing and adding onto the conversation from #187303. This was tested with the GHINB branch
joh/civic-tahr
This PR:
The current logs from this branch with the change above are as follows when explicitly saving a GHINB
joh/civic-tahr
branch"notebook.codeActionsOnSave": { "notebook.source.normalizeVariableNames": "explicit" }
ctrl + s
to explicitly saveThe provider is created, and now only called against the first cell of the notebook upon an explicit save.