Create an IQuickWidget
#190627
Merged
Create an IQuickWidget
#190627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, I've pulled `QuickInputController` into its own file since `quickInput.ts` was getting too big... And then I made another thing that extends `QuickInput` that hides pretty much everything but does allow for a title bar. This could be useful for more "QuickWebView" type experiences if we wanna light anything like that up.
DonJayamanne
approved these changes
Aug 16, 2023
Krzysztof-Cieslak
pushed a commit
to githubnext/vscode
that referenced
this pull request
Sep 18, 2023
To do this, I've pulled `QuickInputController` into its own file since `quickInput.ts` was getting too big... And then I made another thing that extends `QuickInput` that hides pretty much everything but does allow for a title bar. This could be useful for more "QuickWebView" type experiences if we wanna light anything like that up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this, I've pulled
QuickInputControllerinto its own file sincequickInput.tswas getting too big...And then I made another thing that extends
QuickInputthat hides pretty much everything but does allow for a title bar. This is the thing that will actually have the.widgetproperty, but I can't remove it fromIQuickInputbecause something is already taking advantage of it, so I've marked it deperecated.This could be useful for more "QuickWebView" type experiences if we wanna light anything like that up.