Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update [email protected] #183116

Merged
merged 1 commit into from
May 22, 2023
Merged

chore: update [email protected] #183116

merged 1 commit into from
May 22, 2023

Conversation

deepak1556
Copy link
Collaborator

Fixes #181533
Fixes #179836
Fixes #156723
Fixes #182277

Feature:

@deepak1556 deepak1556 requested a review from bpasero May 22, 2023 13:48
@deepak1556 deepak1556 enabled auto-merge (squash) May 22, 2023 13:49
@deepak1556 deepak1556 self-assigned this May 22, 2023
@deepak1556 deepak1556 added this to the May 2023 milestone May 22, 2023
@deepak1556 deepak1556 merged commit ced29a4 into main May 22, 2023
@deepak1556 deepak1556 deleted the robo/update_electron branch May 22, 2023 14:34
@phisch
Copy link

phisch commented May 24, 2023

Would it be possible to make a bug-fix release for this? As it fixes an issue which crashes vscode quite often for people on wayland with fractional scaling. (#156723)

@deepak1556
Copy link
Collaborator Author

Nightly insiders will contain the fix https://code.visualstudio.com/insiders from tomorrow.

@nudlsoop
Copy link

Thank you thank you thank you for the option to disable UNC access checks.

@schittli
Copy link

Doesn't this shame bother anyone in the VS Code Team??

The VS Code product and developer team did a pretty great job,

while Microsoft Visual Studio has been out of step with state-of-the-art modern SW development for about 10 years and is therefore useless (especially in contrast to tools from JetBrains).

And now the VS Code product and developer team also starts to do shoddy work?

The example around security.allowedUNCHosts describes the new shame of the VS Code team very well:

  1. the product team has not been thinking about which solution is useful and reasonable for this use case
  2. therefore, some solution was developed and distributed. Apparently, the developers didn't realize the problems (I almost can't imagine), or the developers were muzzled.
  3. Customers immediately notice that the "concept" for security.allowedUNCHosts is not usable (In fact: the concept is completely missing)
  4. Now, the VS code team does not solve the actual problem (e.g. that one can add \\domain.com\* into the trusted list or that one can also reference a dynamic list)
  5. Therefore, the VS Code Team is programming a workaround to disable the security feature.

Notabene:
we don't have many servers for the trusted list, but we didn't get it running because the VS Code developers could not complete the very limited feature (what a shame!): At startup, VS Code asks if the data from \\server.com\share\... is trusted, but VS Code does not add this URL to the truster list then 😢

When customers try to add trusted UNC hosts, they have to test many different spellings, but the chance is very small that any will work at all. Only because the VS Code team didn't finish the doc and didn't provide examples.

I would even bet that the reason it doesn't work is because the developers themselves didn't know what notation the UNC whitelist has to be.

It's really a pity, VS Code was a great product.

As the example shows, it takes very little to make it unusable.

Thanks a lot, kind regards,
Thomas

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.