Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: run vscode tests in-order #173056

Closed
wants to merge 3 commits into from
Closed

testing: run vscode tests in-order #173056

wants to merge 3 commits into from

Conversation

connor4312
Copy link
Member

Use proper mocha file load events so that order is retained (instead of running all suites in alphabetical order across the codebase)

Fixes #173016
Fixes #173015

Use proper mocha file load events so that order is retained (instead of running all suites in alphabetical order across the codebase)

Fixes #173016
Fixes #173015
@connor4312 connor4312 enabled auto-merge (squash) February 1, 2023 18:25
@vscodenpa vscodenpa added this to the February 2023 milestone Feb 1, 2023
@connor4312 connor4312 assigned hediet and unassigned connor4312 Feb 1, 2023
@connor4312
Copy link
Member Author

@hediet this should be good to go after the test is fixed 🙂

auto-merge was automatically disabled February 9, 2023 14:00

Merge queue setting changed

@hediet hediet modified the milestones: February 2023, March 2023 Feb 20, 2023
@hediet
Copy link
Member

hediet commented Mar 15, 2023

I spent some hours figuring out why the test fails and I'm still clueless.
Unfortunately, it only fails when running all tests in electron and unfortunately async stack traces don't work.

I think some test T asynchronously creates a disposable when the merge editor tests run.
However, T does not seem to dispose that disposable before the merge editor test finishes, so the merge editor tests marks it as leaking...
I did not figure out which test T is.


Also, I don't think this is a proper fix for the linked issues. It fixes it for VS Code (but even that does not always seem to be the case), but generally jumping tests can still be an issue.

@connor4312
Copy link
Member Author

This came in with other improvements necessary for snapshot tests

@connor4312 connor4312 closed this Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants