Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore pointer events from nested ListViews (#169680)" #171027

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Revert "Ignore pointer events from nested ListViews (#169680)" #171027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/vs/base/browser/ui/list/listWidget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,10 +685,6 @@ export class MouseController<T> implements IDisposable {
return;
}

if (e.browserEvent.defaultPrevented) {
return;
}

const focus = e.index;

if (typeof focus === 'undefined') {
Expand All @@ -713,7 +709,6 @@ export class MouseController<T> implements IDisposable {
this.list.setSelection([focus], e.browserEvent);
}

e.browserEvent.preventDefault();
this._onPointer.fire(e);
}

Expand All @@ -726,13 +721,8 @@ export class MouseController<T> implements IDisposable {
return;
}

if (e.browserEvent.defaultPrevented) {
return;
}

const focus = this.list.getFocus();
this.list.setSelection(focus, e.browserEvent);
e.browserEvent.preventDefault();
}

private changeSelection(e: IListMouseEvent<T> | IListTouchEvent<T>): void {
Expand Down
8 changes: 0 additions & 8 deletions src/vs/base/browser/ui/tree/abstractTree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,10 +1358,6 @@ class TreeNodeListMouseController<T, TFilterData, TRef> extends MouseController<
return;
}

if (e.browserEvent.defaultPrevented) {
return;
}

const node = e.element;

if (!node) {
Expand Down Expand Up @@ -1413,10 +1409,6 @@ class TreeNodeListMouseController<T, TFilterData, TRef> extends MouseController<
return;
}

if (e.browserEvent.defaultPrevented) {
return;
}

super.onDoubleClick(e);
}
}
Expand Down