Blacklist typescript.useCodeSnippetsOnMethodSuggest in certain contexts #16415
Conversation
Issue microsoft#2092 **bug** With typescript.useCodeSnippetsOnMethodSuggest enabled, we will automatically complete function calls inside some contexts where they should not be completed. For example, destructing assigment. **fix** Add a quickinfo check on the position before attempting to insert a function call. Create a blacklist of invalid contexts. Otherwise, assume that we want to complete the function call.
|
Nice idea. But we should mark this as a work around and should ask the TS team to provide this information (parameter names) in the completion list result already. There might be cases which we can't easily work around. |
|
@dbaeumer Ok, I'll open an issue on TypeScript. Since TS returns the parameter names already, the request on the TS side would be to not return parameter names when in these assignment contexts, correct? Also, do we want to take this workaround in our side until the TS team can provide a proper fix? |
|
@mjbvz instead of not returning the names I would opt to return a context information in additional that lets us know where we are completing:
|
|
Tracking proper fix on the TS side, but merging in the workaround for now. Will add comment linking to the TS issue in the code |
fixes #2092
bug
With
typescript.useCodeSnippetsOnMethodSuggestenabled, we will automatically complete function calls inside some contexts where they should not be completed. For example, destructing assigments.fix
Add a quickinfo check on the position before attempting to insert a function call. Create a blacklist of invalid contexts. Otherwise, assume that we want to complete the function call.