Fix inlay hints being offset by 1px in some cases #153424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code previously applied the `vertical-align: middle` CSS rule to all hints, even those that have the same font style as the editor's. This results in inlay hints being 1px lower than they should be. This pull request adds the `isUniform` flag to `_getLayoutInfo()`'s output. It indicates if the inlay hint styles and editor styles match. If they do, the `vertical-align` rule is set to `baseline`, effectively disabling it.
|
Thanks @TheV360. Looking much better ✨
|
jrieken
approved these changes
Jun 29, 2022
sandy081
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #153419
VS Code previously applied the
vertical-align: middleCSS rule to all hints, even those that have the same font style as the editor's. This results in inlay hints being 1px lower than they should be.This pull request adds the
isUniformflag to_getLayoutInfo()'s output. It indicates if the inlay hint styles and editor styles match. If they do, thevertical-alignrule is set tobaseline, effectively disabling it.