Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to description #152691

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Add note to description #152691

merged 1 commit into from
Jun 21, 2022

Conversation

rzhao271
Copy link
Contributor

Ref #139247

This PR appends the following sentence to the emmet.useInlineCompletions setting:

To prevent the non-inline completion item provider from showing up as often 
while this setting is `true`, turn `#editor.quickSuggestions#` to 
`inline` or `off` for the `other` item.

A screenshot showing the updated description of the Emmet inline completions setting

An alternative to updating the description is to change the setting itself so it gives the user the option to use the inline completion provider only, but for that case:

  1. We'd need to change the setting from a boolean setting to an enum setting and add in enum values and descriptions.
  2. We would still have to document the fact that the final behaviour depends a lot on the editor.quickSuggestions setting.

@rzhao271 rzhao271 added this to the June 2022 milestone Jun 21, 2022
@rzhao271 rzhao271 requested a review from hediet June 21, 2022 00:35
@rzhao271 rzhao271 self-assigned this Jun 21, 2022
@hediet hediet merged commit 50255ca into main Jun 21, 2022
@hediet hediet deleted the rzhao271/inline-completion-description branch June 21, 2022 12:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants