Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new command to switch between workspaces #11630

Merged
merged 2 commits into from
Sep 8, 2016

Conversation

heycalmdown
Copy link
Contributor

rebase #11493 to clean the mess

@msftclas
Copy link

msftclas commented Sep 7, 2016

Hi @heycalmdown, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.75% when pulling d797ec3 on heycalmdown:switch-workspace into 835e8d7 on Microsoft:master.

@bpasero
Copy link
Member

bpasero commented Sep 7, 2016

@heycalmdown on a second thought, can we rethink the fact that this only shows opened workspaces? imho it would be better to actually show all windows that are opened and call it "Switch Window". Rationale:

  • for your use case it actually would still work because my understanding is that all your windows are just having workspaces associated
  • for other users that want to quickly switch windows, it would be very convenient to be able to use this feature and see all opened windows at a glance

Trying to make this feature more useful to more users 👍

Some related issues:

@bpasero bpasero added this to the September 2016 milestone Sep 7, 2016
@heycalmdown
Copy link
Contributor Author

Okay, sounds reasonable. I'll make it work as you described.

@bpasero
Copy link
Member

bpasero commented Sep 8, 2016

@heycalmdown awesome 👍

@heycalmdown
Copy link
Contributor Author

screen shot 2016-09-08 at 3 18 13 pm

This might take a benefit when having ambiguous workspace and same format with "Open Recent", but looks too verbose. So I settled at this -

screen shot 2016-09-08 at 3 19 46 pm

similar than

screen shot 2016-09-08 at 3 18 36 pm

It'll help the reporter of #2382

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 61.819% when pulling fd1d5e5 on heycalmdown:switch-workspace into 835e8d7 on Microsoft:master.

@heycalmdown
Copy link
Contributor Author

@bpasero time to review now :)

@bpasero bpasero merged commit b1d1fe9 into microsoft:master Sep 8, 2016
@bpasero
Copy link
Member

bpasero commented Sep 8, 2016

@heycalmdown thanks, merged! 👍

@bpasero
Copy link
Member

bpasero commented Sep 8, 2016

Created #11671 to track this for September.

@heycalmdown
Copy link
Contributor Author

Thanks!

@heycalmdown heycalmdown deleted the switch-workspace branch September 20, 2016 07:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants