Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chart color tokens #107201

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Add chart color tokens #107201

merged 2 commits into from
Sep 23, 2020

Conversation

miguelsolorio
Copy link
Contributor

@miguelsolorio miguelsolorio commented Sep 22, 2020 •
edited
Loading

This is for microsoft/vscode-js-debug#756 and adds the following chart color tokens to be used in webviews:

  • charts.foreground
  • charts.lines
  • charts.red
  • charts.blue
  • charts.yellow
  • charts.orange
  • charts.green
  • charts.purple
Dark Light
image image

@miguelsolorio miguelsolorio added this to the September 2020 milestone Sep 22, 2020
@miguelsolorio
Copy link
Contributor Author

Ping @aeschli 😉 we'd like to get this in soon so we can update our webviews

aeschli
aeschli approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@aeschli aeschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelsolorio miguelsolorio merged commit 6447520 into master Sep 23, 2020
@miguelsolorio miguelsolorio deleted the misolori/chart-colors branch September 23, 2020 21:11
robertrossmann added a commit to robertrossmann/vscode-remedy that referenced this pull request Oct 5, 2020
@robertrossmann
feat: add colour contribution points for charts 🎨
e62ad79 
See microsoft/vscode#107201
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connor4312 connor4312 connor4312 approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@connor4312 connor4312

@aeschli aeschli

@miguelsolorio miguelsolorio

Labels
None yet
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelsolorio @connor4312 @aeschli