Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement integrated terminal extension API #10635

Merged
merged 15 commits into from
Aug 19, 2016
Merged

Implement integrated terminal extension API #10635

merged 15 commits into from
Aug 19, 2016

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 17, 2016

Fixes #9957

A demonstration of the API is available at https://github.com/Tyriar/vscode-terminal-api-example

@Tyriar Tyriar added feature-request Request for new features or functionality api terminal General terminal issues that don't fall under another label labels Aug 17, 2016
@Tyriar Tyriar added this to the August 2016 milestone Aug 17, 2016
@Tyriar Tyriar self-assigned this Aug 17, 2016
@Tyriar Tyriar changed the title Tyriar/terminal api Implement integrated terminal extension API Aug 17, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 62.538% when pulling ff87ab3 on tyriar/terminal_api into 9961aa2 on master.

@Tyriar Tyriar removed the feature-request Request for new features or functionality label Aug 18, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Aug 18, 2016

@jrieken could you please take a look and see if everything looks fine?

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 60.327% when pulling 2c95aed on tyriar/terminal_api into 9961aa2 on master.

* @param addNewLine Whether to add a new line to the text being sent, this is normally
* required to run a command in the terminal. This defaults to `true`.
*/
sendText(text: string, addNewLine?: boolean);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always the same sequence for new line or should addNewLine be something like \n|\r\n|\r?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing return type, comment for text

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 60.327% when pulling d3dd3c6 on tyriar/terminal_api into 9961aa2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 60.342% when pulling 2fb2d9a on tyriar/terminal_api into 9961aa2 on master.

@Tyriar Tyriar force-pushed the tyriar/terminal_api branch from ed4d6c0 to 6588805 Compare August 19, 2016 19:26
@Tyriar
Copy link
Member Author

Tyriar commented Aug 19, 2016

Merging but reopening the issue until Terminal.hide() hides the current terminal, not just the panel regardless of which terminal is active.

@Tyriar Tyriar merged commit 75a99c5 into master Aug 19, 2016
@Tyriar Tyriar deleted the tyriar/terminal_api branch August 19, 2016 20:36
@guogaigai
Copy link

Is there any terminal API provided for extension developers to create a terminal with the specified path as the initially start ,thank you @Tyriar

@Tyriar
Copy link
Member Author

Tyriar commented Aug 24, 2016

@guogaigai please just file an issue next time instead of commenting on several issues. This is a good request, I created #10917

@guogaigai
Copy link

thank you very much @Tyriar

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api terminal General terminal issues that don't fall under another label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose integrated terminal extension API
5 participants