-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement integrated terminal extension API #10635
Conversation
@jrieken could you please take a look and see if everything looks fine? |
* @param addNewLine Whether to add a new line to the text being sent, this is normally | ||
* required to run a command in the terminal. This defaults to `true`. | ||
*/ | ||
sendText(text: string, addNewLine?: boolean); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always the same sequence for new line or should addNewLine
be something like \n|\r\n|\r
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing return type, comment for text
ed4d6c0
to
6588805
Compare
Merging but reopening the issue until |
Is there any terminal API provided for extension developers to create a terminal with the specified path as the initially start ,thank you @Tyriar |
@guogaigai please just file an issue next time instead of commenting on several issues. This is a good request, I created #10917 |
thank you very much @Tyriar |
Fixes #9957
A demonstration of the API is available at https://github.com/Tyriar/vscode-terminal-api-example