-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[json] JSONSchema draft 2019-09 support #98724
Comments
(Experimental duplicate detection) |
The implementation will be in https://github.com/microsoft/vscode-json-languageservice |
As an FYI, OpenAPI Specification 3.1 defines using JSON Schema 2020-12. |
Update profiles schema to draft 2020-12 because as mentioned in microsoft/vscode#98724 (comment), OpenAPI Specification 3.1 defines using JSON Schema 2020-12 and VS Code already has early implementation around it. Basically, this just gets rid of the following error shown by VS Code when editing the settings.json file ``` Draft 2019-09 schemas are not yet fully supported. ``` ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Schema updated.
I still see this error in VS Code
Is this fixed? |
What do you mean by fixed? There is no implementation for the 2019-09 version. |
@ajcool2k what do you mean by "There is no implementation for the 2019-09 version."? |
This is clear. My point is, that there cannot be a fix when there is no bug and clearly there is no bug. |
🤷♂️ "Is it fixed?" / "Is my problem resolved now?"
|
I apologize, wrote this on the go. Just found it strange that people joining the discussion of an open feature requesting asking if it is fixed yet :-). Yeah but I agree, will be more polite on this in the feature. Thanks for making me aware of it @Relequestual |
Am working on exercism/problem-specifications#1972 and would love to see more recent drafts supported, even small thinhgs like the support for |
Would love to see support for this. We were considering upgrading a schema we use from draft 07 to draft 2019-09. We are planning to use the Monaco Editor. However, the lack of support means we'll have to skip the upgrade, compromise, or find a different editor. |
I made progress and closed some gaps: See microsoft/vscode-json-languageservice#133 The remaining known gaps are: |
Just a cheerleading comment. Looking forward to meta-schema support. I have a project that needs it badly! |
Cheerleading @aeschli and dancing around my chair for this one to get done :) |
A question: When using |
@stephan-probst Can you file an issue with steps and a sample? I quickly tested and I see code completions. |
Is this issue resolved? I'm a bit confused here. |
3 years later... |
The VSCode Language Service is now on Bowtie: https://bowtie-json-schema.github.io/bowtie/ Bowtie is a multi-implementation tester that uses the official JSON Schema test suite and reports on compliance. It was created and is maintained by members of the JSON Schema team and community. |
Some features just take a while to implement, and 3 years later has seen progress, y'know? :) |
Yep, but this is most like 2019-19 version, I can imagine that this isn't a big effort. |
OpenAPI 3.0.4 released, and we still have this issue |
Even version 3.1 was released in 2021 and this issue is still here :( |
JSONSchema draft-07 is currently supported but
http://json-schema.org/draft/2019-09/schema#
does not currently load, or at least no completion or validation functionality is able to be provided from it.The text was updated successfully, but these errors were encountered: