Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the colon? #9775

Closed
joaomoreno opened this issue Jul 26, 2016 · 8 comments
Closed

Why the colon? #9775

joaomoreno opened this issue Jul 26, 2016 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jul 26, 2016

Testing #9684

Each variable page group seems to end with the colon :, as if there is a value right after it.

image

But there never is 😢

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 26, 2016
@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2016

This was originaly proposed by @weinand
I am fine with removing the colon. @weinand opinion?

@isidorn isidorn added this to the July 2016 milestone Jul 26, 2016
@weinand
Copy link
Contributor

weinand commented Jul 26, 2016

@isidorn what do chrome dev tools in this case?

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2016

@weinand they do not have the colon, and they also do what @joaomoreno proposed in #9774

screen shot 2016-07-26 at 15 25 11

@weinand
Copy link
Contributor

weinand commented Jul 26, 2016

@isidorn we should not only remove the colon in this case but establish the rule that there is only a colon if it is followed by a value.

@weinand
Copy link
Contributor

weinand commented Jul 26, 2016

@isidorn please consider to use the ellipsis character instead of '..'

@joaomoreno
Copy link
Member Author

joaomoreno commented Jul 28, 2016

@isidorn Shouldn't individual indexes not have the array brackets, just like every other key?

image

@joaomoreno joaomoreno reopened this Jul 28, 2016
@weinand weinand assigned weinand and unassigned isidorn Jul 28, 2016
@weinand
Copy link
Contributor

weinand commented Jul 28, 2016

@joaomoreno the brackets of the individual indexes are provided by the backend. They are not created in the VS Code debugger UI.
The current strategy for node-debug is to user brackets for arrays only and to use plain numbers for (well known) data structures that preserve insertion order like Maps or Sets.

@joaomoreno
Copy link
Member Author

That actually makes sense. Closing.

@jrieken jrieken added the verified Verification succeeded label Jul 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants