Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception telemetry filtering for debug adapters #97628

Closed
connor4312 opened this issue May 12, 2020 · 1 comment
Closed

Exception telemetry filtering for debug adapters #97628

connor4312 opened this issue May 12, 2020 · 1 comment
Assignees
@connor4312
Milestone
May 2020

Comments

@connor4312
Copy link
Member

Posthumous issue for #97627 and further tracking.

Isidor mentioned previously that there was filtering for keys beginning
with an underscore, but this was only applied to some data in error
responses, not general telemetry events. An alternative approach to this
is filtering exceptions based on the environment on the extension side,
but I figured it would be better to have VS Code do that so that we
don't end up with N many possibly deviant sets of environment detection
logic.

Some external debug adapters use the vscode-extension-telemetry npm package, in which SteVen already implemented appropriate filtering logic. We just need to ensure that (if the linked PR is the approach to take) all debug adapters that send telemetry events prefix their exception properties with ! so that they can be filtered appropriately.
@connor4312 connor4312 added this to the May 2020 milestone May 12, 2020
@connor4312 connor4312 self-assigned this May 12, 2020
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue May 12, 2020
@connor4312
chore: prefix exception telemetry properties for filtering
da613a2 
Ref: microsoft/vscode#97628
Fixes #464
@connor4312 connor4312 mentioned this issue May 12, 2020
Merged
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue May 12, 2020
@connor4312
chore: prefix exception telemetry properties for filtering
35bb73e 
Ref: microsoft/vscode#97628
Fixes #464
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue May 12, 2020
@connor4312
chore: prefix exception telemetry properties for filtering (#466)
d4a5eaf 
* chore: prefix exception telemetry properties for filtering

Ref: microsoft/vscode#97628
Fixes #464

* fix: don't eat uncaught exceptions in bootloader

Fixes #462
@connor4312 connor4312 mentioned this issue May 12, 2020
Merged
@kieferrm kieferrm mentioned this issue May 18, 2020
Closed
61 tasks
@connor4312
Copy link
Member Author

js-debug and chrome-debug-core have been updated accordingly. Node2 and chrome extensions have been updated and will reach stable with the updated property names the May release.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
None yet
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
1 participant
@connor4312