Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode crashes after pressing ctrl + j #94454

Closed
sunliangqin opened this issue Apr 5, 2020 · 5 comments
Closed

VSCode crashes after pressing ctrl + j #94454

sunliangqin opened this issue Apr 5, 2020 · 5 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
March 2020

Comments

@sunliangqin
Copy link

sunliangqin commented Apr 5, 2020 •
edited
Loading

Issue Type: Bug

I moved all views in panel to sidebar and VSCode crashed the first time I pressed ctrl + j to show panel. I can consistently repro this issue.

VS Code version: Code - Insiders 1.44.0-insider (e8dbc5e, 2020-04-03T23:31:33.481Z)
OS version: Windows_NT x64 10.0.17763
@sunliangqin sunliangqin changed the title VSCode crash after pressing ctrl + j VSCode crashes after pressing ctrl + j Apr 5, 2020
@sbatten sbatten mentioned this issue Apr 6, 2020
Merged
@Tyriar Tyriar added this to the March 2020 milestone Apr 6, 2020
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Apr 6, 2020
sbatten added a commit that referenced this issue Apr 6, 2020
@sbatten
safest refs #94454 (#94566)
15297a9
sbatten added a commit that referenced this issue Apr 6, 2020
@sbatten
safest refs #94454
cf91a9b
@sbatten
Copy link
Member

sbatten commented Apr 6, 2020

To Verify:

  1. Move all panels to the sidebar (panel will hide)
  2. Press Ctrl+J
  3. Check that the panel opens to an empty view e.g. (empty Terminal View) and that you do not crash.

We will iterate on a better UX next milestone.

@sbatten
Copy link
Member

sbatten commented Apr 6, 2020

@sandy081 I made this change as the safest option for now. If you have a better solution that warrants another fix, please take over. Otherwise, will roll with this.

@sbatten sbatten closed this as completed Apr 6, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 6, 2020
@sandy081
Copy link
Member

sandy081 commented Apr 7, 2020

Yah looks the safest fix for now. Seems panel is not ready to handle no active panels. Is there a follow up issue for this created?

@NotWearingPants
Copy link
Contributor

NotWearingPants commented Apr 8, 2020 •
edited
Loading

@sandy081 but the panel does handle no active panels if you run the Focus into Panel command instead of Toggle Panel (Ctrl+J)
image

@sandy081
Copy link
Member

sandy081 commented Apr 8, 2020

Yeah there are some issues with it and it is not working always. Hence we did a safe fix for now. We are working on this with proper UX for next milestone.

@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
6 participants
@sunliangqin @Tyriar @RMacfarlane @sbatten @sandy081 @NotWearingPants