Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking cells has no effect #93956

Closed
isidorn opened this issue Mar 31, 2020 · 2 comments
Closed

Locking cells has no effect #93956

isidorn opened this issue Mar 31, 2020 · 2 comments
Assignees
@rebornix @jrieken
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
March 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

  1. Have the followiing notebook cell
label:debug repo:microsoft/vscode milestone:"March 2020"
  1. Execute it
  2. Lock all cells: I can still edit them 🐛
  3. Lock the current cell: the lock icon does not change, I can still edit the cell 🐛
@isidorn
Copy link
Contributor Author

isidorn commented Mar 31, 2020

Only newly created cells respect the lock. And can not be unlocked 🐛

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Mar 31, 2020
@rebornix rebornix added this to the March 2020 milestone Mar 31, 2020
rebornix added a commit that referenced this issue Mar 31, 2020
@rebornix
Fix #94058, #93956.
563997c
@rebornix
Copy link
Member

Fixed in master.

@isidorn isidorn added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@rebornix @jrieken @isidorn