Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub notebook: better error printing #93893

Closed
isidorn opened this issue Mar 31, 2020 · 2 comments
Closed

GitHub notebook: better error printing #93893

isidorn opened this issue Mar 31, 2020 · 2 comments
Assignees
@jrieken
Labels
notebook polish Cleanup and polish issue
Milestone
March 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

  1. Open a new notebook file, for example isidor.github-issues
  2. Have the following cell
label:debug repo:microsoft/vscode sort desc by comments
  1. Run the query mutiple times until GitHub throttles you
  2. The error is not nicely printed

fyi @rebornix
@jrieken jrieken added this to the March 2020 milestone Mar 31, 2020
@rebornix
Copy link
Member

I'm wondering whether we can use the CellErrorOutput for this.

@jrieken
Copy link
Member

jrieken commented Mar 31, 2020

I didn't look like a good match because (at time I checked) it was very specific to runtime errors, e.g wants a trace and so

jrieken added a commit to microsoft/vscode-github-issue-notebooks that referenced this issue Apr 1, 2020
@jrieken
generate error output, microsoft/vscode#93893
ff32b52
jrieken added a commit that referenced this issue Apr 1, 2020
@jrieken
pring ename and evalue fyi @rebornix, #93893
d9d476d
@jrieken jrieken closed this as completed Apr 1, 2020
@jrieken jrieken added the polish Cleanup and polish issue label Apr 1, 2020
@jrieken jrieken mentioned this issue Apr 1, 2020
Closed
@anthonydresser anthonydresser mentioned this issue Apr 4, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
notebook polish Cleanup and polish issue
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@rebornix @jrieken @isidorn