Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should use role=list #93480

Closed
isidorn opened this issue Mar 26, 2020 · 2 comments
Closed

Terminal should use role=list #93480

isidorn opened this issue Mar 26, 2020 · 2 comments
Assignees
@Tyriar
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
April 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 26, 2020

Forked from #93087 (comment)

Terminal currently uses role=listitem for each line, however it does not set the role=list on the parent container. It should.
More about aria roles can be found here https://w3c.github.io/aria/#list

@Tyriar let me know if you need further help with this.
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues terminal General terminal issues that don't fall under another label labels Mar 26, 2020
@isidorn isidorn mentioned this issue Mar 26, 2020
Closed
@Tyriar Tyriar added this to the April 2020 milestone Apr 5, 2020
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Apr 5, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 5, 2020

Upstream PR: xtermjs/xterm.js#2814

@Tyriar Tyriar closed this as completed in 945ee29 Apr 9, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Apr 9, 2020

Thanks for fixing this!

@connor4312 connor4312 added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2020
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
[email protected]
1ba5140 
xtermjs/xterm.js@c5593bd...21b490f

Link provider fix
- Merge pull request xtermjs/xterm.js#2710 from jmbockhorst/linkFix

Leaked reference
- Merge pull request xtermjs/xterm.js#2767 from JavaCS3/fix/addDisposableDomListener-leak

Missing cursor fix
- Merge pull request xtermjs/xterm.js#2731 from jerch/fix_2729

Accessibility fix
- Merge pull request xtermjs/xterm.js#2814 from Tyriar/role_list

Fixes microsoft#93480

Showcase

Merge pull request xtermjs/xterm.js#2761 from slel/patch-1
Merge pull request xtermjs/xterm.js#2723 from UziTech/patch-1

Test, doc, build improvements

Merge pull request xtermjs/xterm.js#2766 from Tyriar/readme
Merge pull request xtermjs/xterm.js#2786 from Tyriar/eslint
Merge pull request xtermjs/xterm.js#2799 from Tyriar/enum_like_upper_case
Merge pull request xtermjs/xterm.js#2730 from Tyriar/ts38
Merge pull request xtermjs/xterm.js#2753 from jerch/fix_vtfeatures_template
Merge pull request xtermjs/xterm.js#2754 from jerch/fix_vtfeatures_2
Merge pull request xtermjs/xterm.js#2722 from Tyriar/linux_tests
Merge pull request xtermjs/xterm.js#2712 from jmbockhorst/playwright
Merge pull request xtermjs/xterm.js#2800 from Tyriar/upgrade_mac

Many dependency updates

Merge pull request xtermjs/xterm.js#2758 from Tyriar/acorn
Merge pull request xtermjs/xterm.js#2770 from xtermjs/dependabot/npm_and_yarn/deep-eq…
Merge pull request xtermjs/xterm.js#2779 from xtermjs/dependabot/npm_and_yarn/webpack…
Merge pull request xtermjs/xterm.js#2760 from xtermjs/dependabot/npm_and_yarn/acorn-5…
Merge pull request xtermjs/xterm.js#2772 from xtermjs/dependabot/npm_and_yarn/https-p…
Merge pull request xtermjs/xterm.js#2783 from Tyriar/deps
Merge pull request xtermjs/xterm.js#2795 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2801 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2780 from xtermjs/dependabot/npm_and_yarn/types/w…
Merge pull request xtermjs/xterm.js#2792 from xtermjs/dependabot/npm_and_yarn/mocha-7…
Merge pull request xtermjs/xterm.js#2803 from Tyriar/more_deps
Merge pull request xtermjs/xterm.js#2805 from xtermjs/dependabot/npm_and_yarn/mustach…
Merge pull request xtermjs/xterm.js#2810 from xtermjs/dependabot/npm_and_yarn/deep-eq…
Merge pull request xtermjs/xterm.js#2815 from xtermjs/dependabot/npm_and_yarn/nyc-15.0.1
Merge pull request xtermjs/xterm.js#2820 from xtermjs/dependabot/npm_and_yarn/typescr…
Merge pull request xtermjs/xterm.js#2819 from xtermjs/dependabot/npm_and_yarn/typescr…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@isidorn @Tyriar @connor4312