Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance view service to support moving views #87461

Closed
sbatten opened this issue Dec 20, 2019 · 0 comments
Closed

Enhance view service to support moving views #87461

sbatten opened this issue Dec 20, 2019 · 0 comments
Assignees
@sbatten @sandy081
Labels
feature-request Request for new features or functionality on-testplan workbench-views Workbench view issues
Milestone
January 2020

Comments

@sbatten
Copy link
Member

sbatten commented Dec 20, 2019 •
edited
Loading

Part of #85164

ViewsService should provide the interface for moving views allowing it to track view locations and support commands for view movement.
@sbatten sbatten added feature-request Request for new features or functionality workbench-views Workbench view issues labels Dec 20, 2019
@sbatten sbatten added this to the December/January 2020 milestone Dec 20, 2019
This was referenced Dec 20, 2019
Closed
Merged
@sbatten sbatten closed this as completed Jan 13, 2020
sandy081 added a commit that referenced this issue Jan 14, 2020
@sandy081
#87461 Fix open view. Consider existing views.
980d8ef
sandy081 added a commit that referenced this issue Jan 14, 2020
@sandy081
#87461 Small refactorings
3d6aef8 
- Remove cyclic dependency between view descriptor collection and views service
- use view collection for getting and listening on views given a container
- return view descriptor colleciton always for a container
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

@sandy081 sandy081

Labels
feature-request Request for new features or functionality on-testplan workbench-views Workbench view issues
Projects
None yet
Milestone
January 2020
Development

No branches or pull requests
2 participants
@sbatten @sandy081