Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode doc just spell out where codicons are supported #87165

Closed
6 of 29 tasks
jrieken opened this issue Dec 17, 2019 · 9 comments
Closed
6 of 29 tasks

vscode doc just spell out where codicons are supported #87165

jrieken opened this issue Dec 17, 2019 · 9 comments
Assignees
@jrieken
Labels
api polish Cleanup and polish issue
Milestone
February 2020

Comments

@jrieken
Copy link
Member

jrieken commented Dec 17, 2019 •
edited by isidorn
Loading

Today the vscode.d.ts-doc does mention when a string ends up a message (human-readable....) but it doesn't spell out all places in which messages also support the themeicon-syntax, e.g $(zap). These are all messages that use human-readable strings.I can make the doc changes but I need to know if a message support codicon or not.

This is the process:

  • add a ✅ for messages that support codicons
  • do not add a check for messages that don't support codicons
  • last un-assign yourself (I will make a uniform doc update)

This is the list:
@jrieken
Copy link
Member Author

jrieken commented Dec 17, 2019 •
edited
Loading

related to #84695

@jrieken jrieken added this to the December/January 2020 milestone Dec 17, 2019
@jrieken jrieken added api polish Cleanup and polish issue labels Dec 17, 2019
@isidorn isidorn removed their assignment Dec 17, 2019
@isidorn
Copy link
Contributor

isidorn commented Dec 17, 2019

OutputChannel.name does not currently support codicons since the name is shown in the select box dropdown. @sandy081 correct me if I am wrong here and if it was added recently.

@mjbvz mjbvz removed their assignment Dec 17, 2019
@Tyriar Tyriar removed their assignment Dec 27, 2019
@Tyriar
Copy link
Member

Tyriar commented Dec 27, 2019

Terminal names don't (and likely won't ever) support icons

@sandy081
Copy link
Member

sandy081 commented Dec 30, 2019 •
edited
Loading

Yes, OutputChannel.name does not support codicons.

Also Diagnostic.message and Diagnostic.source does not.

@sandy081 sandy081 removed their assignment Dec 30, 2019
@eamodio eamodio removed their assignment Jan 6, 2020
@jrieken jrieken mentioned this issue Jan 7, 2020
Closed
@alexr00
Copy link
Member

alexr00 commented Jan 7, 2020

Task source does support codicons.
TreeView message, TreeItem label, and TreeItem description do not support codicons.

@alexr00 alexr00 removed their assignment Jan 7, 2020
@chrmarti
Copy link
Collaborator

QuickPickItem supports codicons, InputBox's validation message doesn't. (Thanks for filling in.)

@chrmarti chrmarti removed their assignment Jan 24, 2020
jrieken added a commit that referenced this issue Jan 27, 2020
@jrieken
spell out places that support inline theme icons, #87165
3514867
@jrieken
Copy link
Member Author

jrieken commented Jan 27, 2020

@RMacfarlane ping

@jrieken jrieken modified the milestones: January 2020, February 2020 Jan 28, 2020
@RMacfarlane
Copy link
Contributor

@jrieken CommentThread#label, CommentReaction#label, Comment#label, and CommentController#label all do not currently support codicons

@RMacfarlane RMacfarlane removed their assignment Feb 3, 2020
@jrieken
Copy link
Member Author

jrieken commented Feb 4, 2020

Thanks everyone

@jrieken jrieken closed this as completed Feb 4, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api polish Cleanup and polish issue
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
9 participants
@eamodio @jrieken @isidorn @Tyriar @RMacfarlane @chrmarti @sandy081 @mjbvz @alexr00