Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to access conflicting settings #86681

Closed
sandy081 opened this issue Dec 10, 2019 · 2 comments
Closed

Provide a way to access conflicting settings #86681

sandy081 opened this issue Dec 10, 2019 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan settings-sync
Milestone

Comments

@sandy081
Copy link
Member

Provide a way to access conflicting settings so that they can be shown in Settings Editor.

It is needed for #84431

@sandy081 sandy081 added feature-request Request for new features or functionality settings-sync labels Dec 10, 2019
@sandy081 sandy081 added this to the December/January 2020 milestone Dec 10, 2019
@sandy081 sandy081 self-assigned this Dec 10, 2019
@sandy081
Copy link
Member Author

sandy081 commented Jan 8, 2020

Implemented ISettingsSyncService that can provide the state of settings sync and also can access conflicts and resolve them

export interface ISettingsSyncService extends ISynchroniser {
_serviceBrand: any;
getConflicts(): Promise<IConflictSetting[]>;
resolveConflicts(resolvedConflicts: { key: string, value: any | undefined }[]): Promise<void>;
}

@sandy081
Copy link
Member Author

sandy081 commented Jan 9, 2020

Changed the API

export interface ISettingsSyncService extends ISynchroniser {
_serviceBrand: any;
readonly onDidChangeConflicts: Event<IConflictSetting[]>;
readonly conflicts: IConflictSetting[];
resolveConflicts(resolvedConflicts: { key: string, value: any | undefined }[]): Promise<void>;
}

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan settings-sync
Projects
None yet
Development

No branches or pull requests

1 participant