Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation@<number> causes ERR Cannot read property 'title' of undefined #85671

Closed
tamuratak opened this issue Nov 27, 2019 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded
Milestone

Comments

@tamuratak
Copy link
Contributor

Version: 1.41.0-insider
Commit: 615732f
Date: 2019-11-27T05:36:11.009Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 18.7.0

Reproducing #85576.

Steps to Reproduce:

  1. Add the following to package.json in hello-world-sample. This doc is on @<number>
diff --git a/helloworld-sample/package.json b/helloworld-sample/package.json
index 3c5d17f..0552c87 100644
--- a/helloworld-sample/package.json
+++ b/helloworld-sample/package.json
@@ -21,7 +21,16 @@
                                "command": "extension.helloWorld",
                                "title": "Hello World"
                        }
-               ]
+               ],
+               "menus": {
+                       "editor/context": [
+                         {
+                               "command": "extension.helloWorld",
+                               "group": "navigation@100"
+                         }
+                       ]
+               }
+
        },
        "scripts": {
                "vscode:prepublish": "npm run compile",
  1. Execute the sample.
  2. Open a new file and right-click.
  ERR Cannot read property 'title' of undefined: TypeError: Cannot read property 'title' of undefined
    at _compareMenuItems (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1707:336)
    at Array.sort (<anonymous>)
    at e._build (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1706:144)
    at new e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1705:658)
    at createMenu (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1705:361)
    at e._getMenuActions (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1813:213)
    at e.showContextMenu (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1813:77)
    at e._onContextMenu (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1812:915)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1811:927
    at c.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:114:740)
    at s.n.onContextMenu (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2141:461)
    at s.emitContextMenu (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2021:595)
    at t.ViewController.emitContextMenu (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1785:869)
    at g._onContextMenu (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2006:1006)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2005:257
    at HTMLDivElement.<anonymous> (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:554:273)

Does this issue occur when all extensions are disabled?: Yes

@jrieken jrieken self-assigned this Nov 27, 2019
@jrieken jrieken added menus Menu items and widget issues bug Issue identified by VS Code Team member as probable bug labels Nov 27, 2019
@jrieken jrieken added this to the November 2019 milestone Nov 27, 2019
@jrieken
Copy link
Member

jrieken commented Nov 27, 2019

Thanks for the logs and repo steps 👏

devrsi0n pushed a commit to devrsi0n/vscode that referenced this issue Nov 27, 2019
sandy081 pushed a commit that referenced this issue Nov 28, 2019
@mjbvz mjbvz added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants