Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alternative menu command doesn't work #8435

Closed
weinand opened this issue Jun 28, 2016 · 2 comments
Closed

alternative menu command doesn't work #8435

weinand opened this issue Jun 28, 2016 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2016

Comments

@weinand
Copy link
Contributor

weinand commented Jun 28, 2016 •
edited
Loading

Testing #8197:

I tried to configure an alternative command via these contributions:

2016-06-28_22-43-18

But I was not able to make the 'Pocker' menu action to show up.
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jun 29, 2016
@jrieken jrieken added this to the June 2016 milestone Jun 29, 2016
jrieken added a commit that referenced this issue Jun 29, 2016
@jrieken
warn when alt-command isn't supported, #8435
428031b
@jrieken
Copy link
Member

jrieken commented Jun 29, 2016

@weinand Can you pls provide more detail?

@weinand
Copy link
Contributor Author

weinand commented Jun 29, 2016

@jrieken since I had no group specified, the menu item was defaulting to the overflow area where an alt command is not supported. After adding a "group": "navigation" the menu showed up and had an 'alt' command on hover.

It would be more consistent if menu items in the overflow area could show an alt command too.

jrieken added a commit that referenced this issue Jun 29, 2016
@jrieken
refine message about alt-command, #8435
ad3355c
jrieken added a commit that referenced this issue Jun 29, 2016
@jrieken
make sure ALT doesn't stick, #8435
1739c99
@jrieken jrieken closed this as completed Jun 29, 2016
@weinand weinand added the verified Verification succeeded label Jul 4, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
2 participants
@jrieken @weinand