Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Add support emmet for typescript react (tsx) files #732

Closed
okian opened this issue Nov 27, 2015 · 4 comments
Closed

[TypeScript] Add support emmet for typescript react (tsx) files #732

okian opened this issue Nov 27, 2015 · 4 comments
Assignees
@egamma
Labels
feature-request Request for new features or functionality
Milestone
Dec 2015

Comments

@okian
Copy link

okian commented Nov 27, 2015

Please add emmet features for typescript react
@egamma egamma added the feature-request Request for new features or functionality label Nov 27, 2015
@egamma
Copy link
Member

egamma commented Nov 27, 2015

Good idea. Need to explore whether we can just take over the tab key in .tsx files as we do in the other file types.

See also: http://wesbos.com/emmet-react-jsx-sublime/

@deathmood
Copy link

+1 I would like to have emmet also for JavaScript React (in *.jsx files)

@egamma egamma modified the milestone: Backlog Dec 10, 2015
egamma added a commit that referenced this issue Dec 11, 2015
@egamma
Enable emmet in jsx, tsx files #732
f074a4c
@egamma
Copy link
Member

egamma commented Dec 11, 2015

It is now enabled in both jsx and tsx files and for both the jsx filter is used that converts class -> className

@egamma egamma closed this as completed Dec 11, 2015
@bpasero bpasero modified the milestones: Dec 2015, Backlog Dec 17, 2015
@matijagrcic matijagrcic mentioned this issue Dec 21, 2015
Closed
@DanielRosenwasser DanielRosenwasser mentioned this issue Apr 13, 2016
Closed
@mikesigs
Copy link

Apparently the new wisdom is to not use .jsx file extensions, but rather to use .js instead. Can you enable this same functionality for .js extensions too please?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@egamma egamma

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
Dec 2015
Development

No branches or pull requests
5 participants
@egamma @mikesigs @bpasero @deathmood @okian