[json] add commas automatically

[fulldecent]

Test case

Expected behavior

• After typing age TAB, the comma should be added to the end of the previous line.
• After typing " for the next object property, the comma should be added to the end of the previous line.

Actual behavior

The autocomplete does not produce valid text.

Discussion

In general, the autocomplete should strive to produce output that is maximally valid in whatever language grammar it is using.

[apaolino]

It would be useful if could add an automatic comma when you hit the enter key after a line (as Android Studio does)

[brfantauzzi]

Really should be implemented.

[AcerFeng]

You can try Auto Insert Comma .

[AcerFeng]

Really should be implemented.

You can try Auto Insert Comma .

[AcerFeng]

It would be useful if could add an automatic comma when you hit the enter key after a line (as Android Studio does)

You can try Auto Insert Comma .

[ahmafi]

The extension is nice, but wish we had this built-in in VSCode

[peteruithoven]

It's most annoying when you add a { and VS Code auto adds the } at the end.

I get in this situation all the time:

const value = {
  a: "a",
  b: {
    
  }
  c: "c"
}

It's very common in Vue's option syntax for example.

[fulldecent]

@peteruithoven , yes that is in-scope for this issue.

I do not support the behavior of Auto Insert Comma as a default for VS Code.

That extension is adding commas greedily. It is possible for that extension to add a comma that you may not want and which you would have to delete. This proposal is for a default behavior where generally it is nice to err on the side of being correct rather than helpful. And that means adding a comma when it is 100% sure that is desired, including the top post and #69545 (comment).

[zardoy]

I do not support the behavior of Auto Insert Comma as a default for VS Code.

I do not recommend it. It doesn't work with ctrl+Enter & ctrl+shift+Enter correctly, use Fix All JSON instead of Auto Insert Comma for JSON.

However, @fulldecent I'm really interested in your feedback:

That extension is adding commas greedily. ... This proposal is for a default behavior where generally it is nice to err on the side of being correct rather than helpful.

Do you mean that comma shouldn't be inserted after Enter? But when then? After what specific action it should happen?

Also as I read from issue body, autocomplete should have additionalTextEdits to insert , after previous node if needed, but what if next line doesn't have autocomplete items? I didn't really get the idea of feature request.

[fulldecent]

Got it @zardoy, I have updated the expected behavior above and added another behavior that doesn't require auto complete