Revisit need for node/electron-browser in workbench/contrib/preferences

[bpasero]

Refs #68302

I am not sure why src/vs/workbench/contrib/preferences has to have most of its files in electron-browser land. Please consider lifting this to browser if possible.

If there is something blocking this task, speak up and we need to think about introducing new services as needed.

[roblourens]

I need a RequestService. Not sure why the XHR one is in electron-browser?

[bpasero]

Yeah it does not look trivial to move it because it seems the interface it returns has some node dependencies.

Any takers? @chrmarti with your recent proxy work? @joaomoreno ?

I have updated #68302 with:

Implement a IRequestService that works in browser context (using XHR)

[bpasero]

@roblourens to clarify, this service is being used for Bing search support?

[chrmarti]

There already is xhrRequest: IRequestFunction in the requestService.ts, that should be independent of Node. IRequestOptions mixes in an Agent which is Node, but that is not used by xhrRequest which just relies on the browser's proxy support.

[bpasero]

@chrmarti yeah, I was more referring to the stream usage in IRequestOptions and IRequestContext

[roblourens]

Yes @bpasero

[bpasero]

@sandy081 is working on bringing the IRequestService into the browser.

Related/Duplicate: https://github.com/microsoft/vscode/issues/75087

[sandy081]

Request service is now available in web and the interface is moved to common.

Adopted this and now In web, Settings also support bing search.

Closing it.

[sandy081]

Reopening as the request service is not yet functional in web. Working on it.

[sandy081]

After investigating, figured out that request service is functional but the bing results server should be adopted. Will add more details in the other issue.

Since this issue is about moving Preferences search service to browser which is done. So closing this.